SMV netlist: mark properties that were not translated #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
netlist-smv-not-translated
branch
2 times, most recently
from
4fde1d9 to
ebfda0e
Compare
tautschnig
approved these changes
Feb 25, 2025
src/trans-netlist/netlist.cpp
Outdated
Comment on lines
371
to
376
| else | ||
| { | ||
| out << "-- " << id << '\n'; | ||
| out << "-- not translated\n"; | ||
| out << '\n'; | ||
| } |
There was a problem hiding this comment.
Wouldn't it be better to use else if here and have an else UNREACHABLE;?
When a property cannot be mapped to a netlist property, add a comment to the SMV file saying so.
kroening
force-pushed
the
netlist-smv-not-translated
branch
from
ebfda0e to
b6582e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a property cannot be mapped to a netlist property, add a comment to the SMV file saying so.