SMV: convert typecasts to SMV #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
expr2smv-typecast
branch
from
328c22d to
898660b
Compare
kroening
force-pushed
the
expr2smv-typecast
branch
from
898660b to
3615f28
Compare
tautschnig
reviewed
May 15, 2025
src/smvlang/expr2smv.cpp
Outdated
|
|
||
| if(src_width == dest_width) | ||
| { | ||
| // signess change only |
There was a problem hiding this comment.
Nit pick: signess -> signedness
Comment on lines
+257
to
+261
| // Signedness _and_ width change. First go to signed, then extend. | ||
| return convert_rec(smv_extend_exprt{ | ||
| smv_signed_cast_exprt{expr.op(), signedbv_typet{src_width}}, | ||
| dest_width - src_width, | ||
| dest_type}); |
There was a problem hiding this comment.
Can we please have a test that covers this case? I suppose the order of operations makes a difference when the most significant bit is 1.
src/smvlang/expr2smv.cpp
Outdated
| to_signedbv_type(src_type).get_width() == | ||
| to_unsignedbv_type(dest_type).get_width()) | ||
| { | ||
| // signess change only |
Comment on lines
+286
to
+291
| // Signedness _and_ width change. | ||
| // First enlarge, then go unsigned. | ||
| return convert_rec(smv_unsigned_cast_exprt{ | ||
| smv_extend_exprt{ | ||
| expr.op(), dest_width - src_width, signedbv_typet{dest_width}}, | ||
| dest_type}); |
There was a problem hiding this comment.
Again: test would be most appreciated.
src/smvlang/expr2smv.cpp
Outdated
| else if(src_type.id() == ID_signedbv && dest_type.id() == ID_signedbv) | ||
| { | ||
| // signed to signed, width change. | ||
| // Note that resize(...) preserves the sign bit, unlike our typecast. |
There was a problem hiding this comment.
You use extend rather than resize here.
kroening
force-pushed
the
expr2smv-typecast
branch
from
3615f28 to
5b8d0f2
Compare
tautschnig
approved these changes
May 18, 2025
kroening
force-pushed
the
expr2smv-typecast
branch
3 times, most recently
from
4777980 to
485489e
Compare
|
Test added with all 12 cases. |
kroening
force-pushed
the
expr2smv-typecast
branch
from
485489e to
2447060
Compare
This adds conversion for a variety of typecast expressions into SMV syntax.
kroening
force-pushed
the
expr2smv-typecast
branch
from
2447060 to
86c8025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds conversion for a variety of typecast expressions into SMV syntax.