SVA-to-LTL: refactoring to use vector #1112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
sva-to-ltl-refactoring
branch
from
4bd6b87 to
3125442
Compare
tautschnig
approved these changes
May 18, 2025
src/temporal-logic/sva_to_ltl.cpp
Outdated
Comment on lines
34
to
36
| explicit ltl_sequence_matcht(exprt __cond) | ||
| { | ||
| cond_vector.push_back(std::move(__cond)); | ||
| } |
There was a problem hiding this comment.
Suggested change
| explicit ltl_sequence_matcht(exprt __cond) | |
| { | |
| cond_vector.push_back(std::move(__cond)); | |
| } | |
| explicit ltl_sequence_matcht(exprt __cond) : cond_vector(1, std::move(__cond)) | |
| { | |
| } |
src/temporal-logic/sva_to_ltl.cpp
Outdated
| { | ||
| auto &c = cond_vector[i]; | ||
| if(!c.is_true()) | ||
| conjuncts.push_back(n_Xes(i, cond_vector[i])); |
There was a problem hiding this comment.
Suggested change
| conjuncts.push_back(n_Xes(i, cond_vector[i])); | |
| conjuncts.push_back(n_Xes(i, c)); |
This refactors the SVA-to-LTL sequence translation to return a vector instead of an expression. This makes it easier to implement the sequence repetition operators.
kroening
force-pushed
the
sva-to-ltl-refactoring
branch
from
3125442 to
2edd9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the SVA-to-LTL sequence translation to return a vector instead of an expression. This makes it easier to implement the sequence repetition operators.