Skip to content

Verilog: directives inside `include argument #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

kroening
Copy link
Member

@kroening kroening commented Dec 7, 2024

This changes the behavior when processing a Verilog preprocessor `include directive.

  1. When the argument contains a directive, a better error message is issued. Other tools process (at least some) directives within the argument.

  2. When the argument is a file name enclosed in " quotes, the character sequence is used as is, and no string literal processing is performed. This behavior matches what other tools implement.

Note that 1800-2017 does not specify the required behavior for either one of these scenarios.

@kroening kroening changed the title Verilog: directives inside ``include argument Verilog: directives inside `include argument Dec 7, 2024
This changes the behavior when processing a Verilog preprocessor `include
directive.

1.  When the argument contains a directive, a better error message is
issued.  Other tools process (at least some) directives within the argument.

2.  When the argument is a file name enclosed in " quotes, the character
sequence is used as is, and no string literal processing is performed.  This
behavior matches what other tools implement.

Note that 1800-2017 does not specify the required behavior for either one of
these scenarios.
@kroening kroening force-pushed the verilog-include-with-directive branch from 00098b3 to e4082d1 Compare December 7, 2024 16:55
@kroening kroening marked this pull request as ready for review December 7, 2024 16:59
@tautschnig tautschnig merged commit 12b3d47 into main Dec 9, 2024
9 checks passed
@tautschnig tautschnig deleted the verilog-include-with-directive branch December 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants