Skip to content

Docs: Eclipse JDT invalid links, also how to use offline #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scscgit opened this issue Aug 17, 2024 · 1 comment
Closed

Docs: Eclipse JDT invalid links, also how to use offline #2227

scscgit opened this issue Aug 17, 2024 · 1 comment

Comments

@scscgit
Copy link

scscgit commented Aug 17, 2024

README.md section eclipse-jdt contains links:

By googling for the version, I actually thought this is supposed to be a reference to https://mvnrepository.com/artifact/com.diffplug.spotless/spotless-eclipse-jdt, which has version 4.8.1 (which also has major 4, so it looked similar) and is also under this package. But using eclipse("4.8.1") in Gradle causes error:

Caused by: java.lang.NumberFormatException: For input string: "8.1"
	at com.diffplug.spotless.extra.EquoBasedStepBuilder.addPlatformRepo(EquoBasedStepBuilder.java:86)

which isn't very user-friendly tbh.

Additionally, I'd like to ask you to document the behavior of these libraries. When we specify a version number, where exactly does it download and "cache" anything, i.e. can we explicitly specify Gradle dependencies for it, so that there is absolutely no API call against any live third-party domain when we build our project? And when we don't specify any version, does it use latest as defined by our Spotless plugin version, or does it actually pull the latest changes after each build, which could actually break our build (and introduce security risks)? Thanks.

Versions:
Gradle 8.9
id("com.diffplug.spotless") version "7.0.0.BETA1"
Windows 10

@nedtwigg
Copy link
Member

The spotless-eclipse-jdt artifact is dead, we couldn't maintain compat with new Eclipse versions that way (thus it died out at 4.8.1)

  • when we don't specify any version, does it use latest as defined by our Spotless plugin version
    • yes, it doesn't just grab "latest", the default is pinned within the Spotless version
  • where exactly does it download and "cache" anything

nedtwigg added a commit that referenced this issue Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants