-
Notifications
You must be signed in to change notification settings - Fork 19
Add separate install instructions for macOS Arm64 users in readme #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sbillinge ready for review - Codecov error is occuring for some reason. I will address it in the next PR. |
I will try to re-run the CI with an empty commit. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 98.96% 98.96%
=======================================
Files 6 6
Lines 1261 1261
=======================================
Hits 1248 1248
Misses 13 13 |
@sbillinge okay.. it was a glitch. Codecov works now. |
let's remove this from the installation in the readme (and the docs if it is there), it is just confusing: diffpy.pdffit2 supports Python 3.11 and 3.12 the following external software:
Also, something happened to the rendering of the "conda config --add channels conda-forge". Other than that it looks great! |
@sbillinge Got it. the ![]() |
Nicely done. Let me know when we are ready for PDFgui/PDF fit 2 release. |
Closes #86
Closes #24
Here is the rendered version of the REAMDE:
https://github.com/bobleesj/diffpy.pdffit2/tree/readme-install?tab=readme-ov-file#installation