Skip to content

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Dec 4, 2024

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 4, 2024

@sbillinge ready for review - Codecov error is occuring for some reason. I will address it in the next PR.

@bobleesj bobleesj marked this pull request as ready for review December 4, 2024 16:01
@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 4, 2024

I will try to re-run the CI with an empty commit.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.96%. Comparing base (cf12149) to head (207fb45).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           6        6           
  Lines        1261     1261           
=======================================
  Hits         1248     1248           
  Misses         13       13           

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 4, 2024

@sbillinge okay.. it was a glitch. Codecov works now.

@sbillinge
Copy link
Contributor

let's remove this from the installation in the readme (and the docs if it is there), it is just confusing:

diffpy.pdffit2 supports Python 3.11 and 3.12 the following external software:

setuptools - software distribution tools for Python
python-dev - header files for interfacing Python with C
GSL - GNU Scientific Library for C
g++ - GNU C++ compiler
diffpy.structure - simple storage and manipulation of atomic structures, https://github.com/diffpy/diffpy.structure

Also, something happened to the rendering of the "conda config --add channels conda-forge".

Other than that it looks great!

@bobleesj
Copy link
Contributor Author

bobleesj commented Dec 5, 2024

@sbillinge Got it. the conda config --add channels conda-forge" is fixed and also removed dependencies for building.

Screenshot 2024-12-04 at 10 04 51 PM

@sbillinge sbillinge merged commit 1b0de23 into diffpy:main Dec 5, 2024
5 checks passed
@sbillinge
Copy link
Contributor

Nicely done. Let me know when we are ready for PDFgui/PDF fit 2 release.

@bobleesj bobleesj deleted the readme-install branch December 5, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update installation instruction for macOS Arm64 users in README.md v1.4.3 distributions for Mac Silicon and Noarch?

2 participants