Skip to content

Conversation

8bitsam
Copy link
Contributor

@8bitsam 8bitsam commented Jul 27, 2024

Test on different OS's and all supported python versions.

@8bitsam
Copy link
Contributor Author

8bitsam commented Jul 27, 2024

It seems like a workaround needs to be found to get the tests running on mac, it wasn't able to find the gcc and g++ packages from environment.yml.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super. Thanks for getting this going. I left an inine comment that we probably want to add macos-latest (or whatever the syntax is) to test on different arm platforms too? What do you think? I will merge this though and we do that on a new PR

matrix:
os: ["ubuntu-latest"]
python-version: ['3.10', '3.11', '3.12']
os: ["ubuntu-latest", "windows-latest"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need macos-latest to get it to test on the arm platforms?

@sbillinge sbillinge merged commit 3459ee7 into diffpy:cookie Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants