Skip to content

Conversation

rijkvanzanten
Copy link
Member

@rijkvanzanten rijkvanzanten commented Aug 26, 2025

We were using .prevent which stops all keydown events, including tabbing when going through a page. This ensures we only call preventDefault when a key was pressed we're handling.

Fixes #31

@rijkvanzanten rijkvanzanten requested a review from Copilot August 26, 2025 17:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an accessibility issue where the split panel component was preventing all keydown events, including navigation keys like Tab. The fix ensures only handled keys (arrow keys, Home, End, Enter) have their default behavior prevented while allowing other keys to function normally.

  • Moved preventDefault call inside the key handling logic to only apply to handled keys
  • Removed the .prevent modifier from the template to allow unhandled keys to bubble up

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rijkvanzanten rijkvanzanten merged commit a11b4b6 into main Aug 26, 2025
3 checks passed
@rijkvanzanten rijkvanzanten deleted the rijk/31 branch August 26, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab key is prevented
1 participant