Skip to content

Use a StreamReader instead of TextReader to avoid synchronous IO #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Conversation

jmazouri
Copy link
Contributor

Requests throw an exception on recent 3.0 SDK versions otherwise, see dotnet/aspnetcore#7644

Requests throw an exception on recent 3.0 SDK versions otherwise, see dotnet/aspnetcore#7644
@jmazouri
Copy link
Contributor Author

Apparently this doesn't fix the issue entirely, as json.net still tries to use a textwriter...

Can probably be removed after 3.0 releases properly
@Cisien Cisien merged commit b4a4b78 into discord-csharp:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants