Skip to content

Fix the build #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2018
Merged

Fix the build #89

merged 4 commits into from
Jul 15, 2018

Conversation

jrusbatch
Copy link
Member

Our CI build is currently failing due to a missing reference to Discord.Net from Modix.Data. This PR adds that missing reference and also removes explicit references to the Microsoft.NETCore.App package that were causing warnings on build.

@Cisien
Copy link
Collaborator

Cisien commented Jul 14, 2018

there was an issue with the postgres library that required keeping the netcore.app reference around until the postgres lib could be packaged correctly... has that resolved? dotnet/aspnetcore#3221

@jrusbatch
Copy link
Member Author

The solution builds and starts running for me with these changes, so I don't think they reintroduce that issue.

@jmazouri jmazouri requested a review from Cisien July 15, 2018 18:25
@jmazouri jmazouri merged commit e414bfd into discord-csharp:master Jul 15, 2018
@jrusbatch jrusbatch deleted the fix-build branch July 15, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants