-
Notifications
You must be signed in to change notification settings - Fork 588
fix: Relect template block structure of Django 5.2+ #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request addresses compatibility issues with Django 5.2 by updating the template structure and dependencies. The primary change involves adjusting the template blocks in No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes - here's some feedback:
Overall Comments:
- It would be good to have a test case that verifies the fix for the reported issue.
- Consider adding a comment in the template explaining why the
object-tools
block is being emptied.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get this merged and released 🚢 🚀
Description
Django 5.2 changes the block structure of the admin base template:
This PR reflects this (otherwise leading to the object tools being shown twice #1522 ) by replacing the
block object tools by
{% block filer-tools %}
.Fixes #1522
Attention
Custom filer templates might need to be adjusted for django 5.2 or later. (This is an immediate effect of the (breaking) change in django 5.2).
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.
Summary by Sourcery
Update Django admin template blocks to be compatible with Django 5.2's new template structure
Bug Fixes:
Enhancements:
Documentation:
Summary by Sourcery
Update Django admin template block structure to be compatible with Django 5.2+ by replacing object-tools block with filer-tools block
Bug Fixes:
Enhancements:
Documentation: