fix postgis explain #1130
Closed
fix postgis explain #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
suggested changes
May 24, 2019
jieter
added a commit
to jieter/django-debug-toolbar
that referenced
this pull request
Dec 22, 2020
Without this fix, pushing the 'sel' or 'explain' button for a query containing some EWKB-encoded geometry
as parameter results in this crash:
```
Internal Server Error: /__debug__/sql_explain/
Traceback (most recent call last):
File "/Users/jieter/.pyenv/versions/obs/lib/python3.8/site-packages/django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
psycopg2.errors.InternalError_: parse error - invalid geometry
LINE 1: ...ure" IN (0, 1, 5)) AND "waarneming"."geo_point" @ 'ST_GeomFr...
^
HINT: "ST" <-- parse error at position 2 within geometry
```
I'm not sure if this is the appropriate location in the code, but with this fix, both `sql_select` and `sql_explain`
work without flaws.
Previous PR adding a similar fix: django-commons#1130
Fixes: django-commons#423
jieter
added a commit
to jieter/django-debug-toolbar
that referenced
this pull request
Oct 26, 2021
Without this fix, pushing the 'sel' or 'explain' button for a query containing some EWKB-encoded geometry
as parameter results in this crash:
```
Internal Server Error: /__debug__/sql_explain/
Traceback (most recent call last):
File "/Users/jieter/.pyenv/versions/obs/lib/python3.8/site-packages/django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
psycopg2.errors.InternalError_: parse error - invalid geometry
LINE 1: ...ure" IN (0, 1, 5)) AND "waarneming"."geo_point" @ 'ST_GeomFr...
^
HINT: "ST" <-- parse error at position 2 within geometry
```
I'm not sure if this is the appropriate location in the code, but with this fix, both `sql_select` and `sql_explain`
work without flaws.
Previous PR adding a similar fix: django-commons#1130
Fixes: django-commons#423
auvipy
pushed a commit
that referenced
this pull request
Oct 26, 2021
Without this fix, pushing the 'sel' or 'explain' button for a query containing some EWKB-encoded geometry
as parameter results in this crash:
```
Internal Server Error: /__debug__/sql_explain/
Traceback (most recent call last):
File "/Users/jieter/.pyenv/versions/obs/lib/python3.8/site-packages/django/db/backends/utils.py", line 86, in _execute
return self.cursor.execute(sql, params)
psycopg2.errors.InternalError_: parse error - invalid geometry
LINE 1: ...ure" IN (0, 1, 5)) AND "waarneming"."geo_point" @ 'ST_GeomFr...
^
HINT: "ST" <-- parse error at position 2 within geometry
```
I'm not sure if this is the appropriate location in the code, but with this fix, both `sql_select` and `sql_explain`
work without flaws.
Previous PR adding a similar fix: #1130
Fixes: #423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error that arises when trying to explain a query that involves a geometry field when using django's GEOManager
the arises from this django line of code https://github.com/django/django/blob/b9cf764be62e77b4777b3a75ec256f6209a57671/django/contrib/gis/db/backends/postgis/adapter.py#L59
that executes only when using postgis backend.
This fixes a related issue that was closed without a fix #423