Skip to content

Remove undocumented djdt.init() from the exported namespace #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove undocumented djdt.init() from the exported namespace #1287

wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Contributor

The function is not documented and there is no reason a third party
panel would need to call init() a 2nd time.

The function is not documented and there is no reason a third party
panel would need to call init() a 2nd time.
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #1287 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   86.61%   86.74%   +0.13%     
==========================================
  Files          25       25              
  Lines        1449     1449              
  Branches      205      205              
==========================================
+ Hits         1255     1257       +2     
+ Misses        142      141       -1     
+ Partials       52       51       -1     
Impacted Files Coverage Δ
debug_toolbar/panels/profiling.py 91.07% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c44d9...4637103. Read the comment docs.

@matthiask
Copy link
Member

djdt.init was made available for supporting TurboLinks and similar software, so there's a good reason for it being part of the public API. Or maybe there exists a better way to accomplish this but exporting init certainly works.

@matthiask
Copy link
Member

Here's the pull request which exported djdt.init: #1180

@jdufresne
Copy link
Contributor Author

Thanks for that link. I'll take a deeper look into that issue and try to grok it.

@jdufresne jdufresne closed this May 21, 2020
@jdufresne jdufresne deleted the init-private branch May 21, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants