-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Patch default cache when using the cache panel #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -3,9 +3,20 @@ | |||||||||||||||
import time | ||||||||||||||||
from collections import OrderedDict | ||||||||||||||||
|
||||||||||||||||
try: | ||||||||||||||||
from django.utils.connection import ConnectionProxy | ||||||||||||||||
except ImportError: | ||||||||||||||||
# Django 3.1 and below doesn't have a ConnectionProxy | ||||||||||||||||
pass | ||||||||||||||||
|
||||||||||||||||
from django.conf import settings | ||||||||||||||||
from django.core import cache | ||||||||||||||||
from django.core.cache import CacheHandler, caches as original_caches | ||||||||||||||||
from django.core.cache import ( | ||||||||||||||||
DEFAULT_CACHE_ALIAS, | ||||||||||||||||
CacheHandler, | ||||||||||||||||
cache as original_cache, | ||||||||||||||||
caches as original_caches, | ||||||||||||||||
) | ||||||||||||||||
from django.core.cache.backends.base import BaseCache | ||||||||||||||||
from django.dispatch import Signal | ||||||||||||||||
from django.middleware import cache as middleware_cache | ||||||||||||||||
|
@@ -246,8 +257,14 @@ def enable_instrumentation(self): | |||||||||||||||
else: | ||||||||||||||||
cache.caches = CacheHandlerPatch() | ||||||||||||||||
|
||||||||||||||||
try: | ||||||||||||||||
cache.cache = ConnectionProxy(cache.caches, DEFAULT_CACHE_ALIAS) | ||||||||||||||||
except NameError: | ||||||||||||||||
pass | ||||||||||||||||
Comment on lines
+260
to
+263
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||
|
||||||||||||||||
def disable_instrumentation(self): | ||||||||||||||||
cache.caches = original_caches | ||||||||||||||||
cache.cache = original_cache | ||||||||||||||||
# While it can be restored to the original, any views that were | ||||||||||||||||
# wrapped with the cache_page decorator will continue to use a | ||||||||||||||||
# monkey patched cache. | ||||||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.