Keep the toolbar handle in bounds #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The additional translateY makes djdt.top=0 move the handle to the top of the browser window. - Because the handle is rotated we have to subtract its offsetWidth, not its offsetHeight to keep it in bounds at the bottom of the window.
Codecov Report
@@ Coverage Diff @@
## main #1472 +/- ##
=======================================
Coverage 86.23% 86.23%
=======================================
Files 35 35
Lines 1853 1853
Branches 260 260
=======================================
Hits 1598 1598
Misses 182 182
Partials 73 73 Continue to review full report at Codecov.
|
tim-schilling
approved these changes
May 14, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.