Skip to content

Version 3.2.2 #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Version 3.2.2 #1492

merged 2 commits into from
Aug 14, 2021

Conversation

tim-schilling
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1492 (f65d86b) into main (f4c263a) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
- Coverage   86.58%   86.42%   -0.17%     
==========================================
  Files          35       35              
  Lines        1864     1864              
  Branches      262      262              
==========================================
- Hits         1614     1611       -3     
- Misses        178      181       +3     
  Partials       72       72              
Impacted Files Coverage Δ
debug_toolbar/__init__.py 66.66% <100.00%> (ø)
debug_toolbar/panels/profiling.py 86.60% <0.00%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c263a...f65d86b. Read the comment docs.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

It now waits for make example to process the db migrations before
selenium browses out.

It also handles toolbar already being open in the case of existing
cookies.
@tim-schilling
Copy link
Member Author

In the process of trying to take a screenshot, I ran into a few issues (that I caused when making make example more robust months ago). I made the screenshot.py script a bit more robust to account for that.

@tim-schilling tim-schilling merged commit f65d86b into main Aug 14, 2021
@tim-schilling tim-schilling deleted the v3.2.2 branch August 14, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants