Skip to content

Add Django 4.0a1 to tox.ini #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Add Django 4.0a1 to tox.ini #1508

merged 2 commits into from
Sep 28, 2021

Conversation

matthiask
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1508 (696ebb8) into main (1a3caba) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   86.42%   85.89%   -0.53%     
==========================================
  Files          35       35              
  Lines        1893     1893              
  Branches      276      276              
==========================================
- Hits         1636     1626      -10     
- Misses        182      187       +5     
- Partials       75       80       +5     
Impacted Files Coverage Δ
debug_toolbar/views.py 75.00% <0.00%> (-25.00%) ⬇️
debug_toolbar/panels/history/panel.py 90.38% <0.00%> (-5.77%) ⬇️
debug_toolbar/panels/templates/views.py 62.79% <0.00%> (-4.66%) ⬇️
debug_toolbar/panels/headers.py 95.45% <0.00%> (-4.55%) ⬇️
debug_toolbar/middleware.py 95.00% <0.00%> (-1.67%) ⬇️
debug_toolbar/panels/profiling.py 89.28% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3caba...696ebb8. Read the comment docs.

tox.ini Outdated
py{36,37,38,39}-dj{22,31,32}-{postgresql,mysql}
py{310}-dj{32,main}-{sqlite,postgresql,mysql}
py{310}-dj{32,40,main}-{sqlite,postgresql,mysql}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

py{38,39}-{40,main}-{postgresql,mysql} is missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, thanks!

I'm so confused by this matrix 😅

Copy link

@felixxm felixxm Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, maybe:

    py{36,37}-dj{22,31,32}-{sqlite,postgresql,mysql}
    py{38,39}-dj{22,31,32,40,main}-{sqlite,postgresql,mysql}
    py{310}-dj{40,main}-{sqlite,postgresql,mysql}

it's more readable to me 🤔

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django 3.2 doesn't officially support Python 3.10.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful, thank you!

@matthiask matthiask merged commit 1a5a761 into main Sep 28, 2021
@matthiask matthiask deleted the mk/dj40 branch September 28, 2021 07:52
@tim-schilling
Copy link
Member

As a point of clarification, I intended for the dj-main case to only be tested with sqlite. The reasoning was that it's used as a canary for upcoming incompatible changes and we don't need to test every permutation for it. I'm fine with the changes made in this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants