-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Django 4.0a1 to tox.ini #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 86.42% 85.89% -0.53%
==========================================
Files 35 35
Lines 1893 1893
Branches 276 276
==========================================
- Hits 1636 1626 -10
- Misses 182 187 +5
- Partials 75 80 +5
Continue to review full report at Codecov.
|
tox.ini
Outdated
py{36,37,38,39}-dj{22,31,32}-{postgresql,mysql} | ||
py{310}-dj{32,main}-{sqlite,postgresql,mysql} | ||
py{310}-dj{32,40,main}-{sqlite,postgresql,mysql} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
py{38,39}-{40,main}-{postgresql,mysql}
is missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thanks!
I'm so confused by this matrix 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, maybe:
py{36,37}-dj{22,31,32}-{sqlite,postgresql,mysql}
py{38,39}-dj{22,31,32,40,main}-{sqlite,postgresql,mysql}
py{310}-dj{40,main}-{sqlite,postgresql,mysql}
it's more readable to me 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Django 3.2 doesn't officially support Python 3.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful, thank you!
As a point of clarification, I intended for the |
No description provided.