Consolidate csp_nonce usages to a single property on the toolbar. #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhudson
reviewed
Mar 14, 2025
| @@ -25,7 +25,7 @@ deps = | |||
| pygments | |||
| selenium>=4.8.0 | |||
| sqlparse | |||
| django-csp<4 | |||
| django-csp | |||
There was a problem hiding this comment.
Since the django-csp v4 releases are beta, a pre-release, will this pick up v3.8, the last published release? I'm not up on if the intention here is to test against v4 or v3.x but I believe django-csp has solved this issue for both versions anyway by adding the CheckableLazyObject in the v4 betas.
There was a problem hiding this comment.
Yes, we test against pre-releases in ci. I think that's why we caught this early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
docs/changes.rst.