Skip to content

Remove Type Hints from CspRenderingTestCase #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andoriyaprashant
Copy link
Member

Description

This PR removes explicit type annotations and unnecessary imports from the CspRenderingTestCase class as suggested in #2087

  • Changes made:
    • Removed all type hints within the CspRenderingTestCase methods (ex - root: Element, namespaces: dict[str, str], etc.).
    • Removed unused cast, Element, and ContextList imports.
    • Preserved all logic and test behavior - only typing-related changes were made.

Fixes # 2087

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly sad, but I have to say it looks less noisy. The annotations for basic functions look good, but cast really doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants