Convert ajaxcomments.js to jQuery plugin

[euanlau]

Have you considered rewriting the thing to a proper jQuery plugin?
Right now it is just a bunch functions in the global namespace. It would be nice to convert it to a configurable plugin.

[vdboor]

Hi, I didn't consider this, but I think that's an excellent idea! I'm currently busy with improvements in other fluent-* apps, so I hope you can find time for this. I'll happily accept a pull request for such rewrite. :)

[euanlau]

I have been rewriting it for a project that I have been working on. I will submit a pull request once it is in a better shape.

There are two advantages at least:

1. configurable
2. handle the case when the comments list/form are loaded via javascript/ajax
   e.g.

$.ajax({ 
    url: 'comments list/form url'
    success: function() {
        ... load comments list/form html...
        $(.comments-container).fluentcomments({
            append: true
        })
   }
});

[vdboor]

Cool, I'm looking forward to it! Does your rewrite also include the latest changes in master?

[euanlau]

Here is the rewritten version. It is missing something from the master branch since I rewrote it based on an older version. But please take a look and see if it is on the right track.

https://github.com/euanlau/django-fluent-comments/blob/fd5af939b703993b5c029943f244a8c79b9ba18c/fluent_comments/static/fluent_comments/js/ajaxcomments.js

[vdboor]

Hi @euanlau, that's definitely on the right track! You may also want to look into the Twitter-bootstrap code, they've implemented a pretty nice way to do jQuery plugins as well which I prefer

The master branch has some pretty invasive changes for multi-form support. I guess that would be much easier to implement when the code operates as jQuery plugin. (though it would involve updating the selectors/ID's code)

[rosscdh]

I've also created a jQuery plugin version here https://gist.github.com/rosscdh/6637741

Its currently working and takes into an edge-case of ours.

Ive not tested it with the preview (as we do'nt use preview currently). But as the requirement arises Ill be developing it further.

[xsanch]

Any progress on rewriting the latest version of fluent comments to jquery ? I am using AJAX to fetch comment forms ..

[rosscdh]

@xsanch I got this far: https://gist.github.com/rosscdh/6637741

[xsanch]

Any progress on this , it has been already one year since this issue was opened.

Regards,

Jorge

[rosscdh]

The gist I provided above still works quite well. I've not heard back from core devs on the topic either.

[vdboor]

The gist I provided above still works quite well. I've not heard back from core devs on the topic either.

Ok, I wasn't under the impression that this was release quality already. Being a gist didn't mean that much for me. Seriously, if someone can provide a working pull request that implements the whole thing I'd be more then happy to accept it and release a new version. The current code style annoys the **ll out of me too, I'd love to see that replaced. Being a jQuery plugin is a big bonus for custom scripting.

[rosscdh]

@vdboor Hey no problems; ill do that asap (am a little under load atm) but would be happy to.