Skip to content

JSON API 1.1: return included array even if nothing is included #1109

Open
@sliverc

Description

@sliverc

Description of feature request

Currently, when there are no included resources, there is no included key. However, as of JSON API 1.1 this is required and in older versions it is certainly allowed. So whenever a user has requested includes with the query parameter include an included key needs to be part of the result. But only then. If there is no include query parameter, no include should be added.

Checklist

  • Raised initially as discussion Adding support for JSON:API v1.1 #1092
    This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where feasible.)
    I have reduced the issue to the simplest possible case.

Activity

Anirudh3167

Anirudh3167 commented on Jun 4, 2023

@Anirudh3167

#1153 has the enhancement

Anirudh3167

Anirudh3167 commented on Jun 6, 2023

@Anirudh3167

Hey @sliverc I have issued the PR #1153
Kindly review and merge it.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sliverc@Anirudh3167

        Issue actions

          JSON API 1.1: return included array even if nothing is included · Issue #1109 · django-json-api/django-rest-framework-json-api