Error pointer always refers to the attributes

[jkostrzewski]

If I do a POST request with data containing a relationship:

{
    "data": {
        "type": "comment",
        "attributes": {
            "text": "comment text"
        },
        "relationships": {
            "author": {
                "data": {
                    "id": "1 (invalid id)",
                    "type": "author"
                }
            }
        }
    }
}

I got the following response:

{
    "errors": [{
        "status": "400",
        "source": {"pointer": "/data/attributes/author"}, 
        "detail": "Error message"
    }]
}

But would rather expect the following response:

{
    "errors": [{
        "status": "400",
        "source": {"pointer": "/data/relationships/author"}, 
        "detail": "Error message"
    }]
}

So the two responses are different when it comes to source/pointer.
Which version is the proper one? According to the specs the pointer should point to the associated entity in the request document.

[kujbol]

Hello is there any progress on this issue? It is blocking one of our feature

[sliverc]

Thanks for your bug report. There is currently no-one working on. It would be very welcome if you could work on a PR though.

[platinumazure]

Hi @sliverc, I'm interested in looking at this one.

I see that #815 added tests to the old example.tests module and also used snapshots. What would you recommend for this issue if I want to add tests in the new tests module? Are snapshots compatible with your vision for tests moving forward?

[sliverc]

@platinumazure Snapshot testing is certainly something we want to continue in the future. I am not so sure about the testing style in test_errors.py module though as it is quite repetitive and could be simplified with some pytest features.

I need to look into this later on anyway. So for a quick fix of this particular issue feel free to add the test to the old example/tests/test_errors.py module.

[sliverc]

For someone who wants to take this up best start looking at the code here.

[mehdy]

@sliverc Hi, would you mind if I work on this issue?

[sliverc]

@mehdy go for it that would be great