Skip to content

Ensure that all external links are https #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
sliverc opened this issue Sep 29, 2021 · 8 comments · Fixed by #989
Closed
2 tasks done

Ensure that all external links are https #984

sliverc opened this issue Sep 29, 2021 · 8 comments · Fixed by #989
Labels

Comments

@sliverc
Copy link
Member

sliverc commented Sep 29, 2021

Description of the Bug Report

There are several links in our website which refer to http:// instead of https:// even though most linked sites actually provide https. Those links should be updated to all use https.

Quick search

$ git grep "http://" | grep -v testserver | grep -v localhost | grep -v "127.0.0.1" | grep -v example.com | grep -v example.org

CHANGELOG.md:Note that in line with [Django REST framework policy](http://www.django-rest-framework.org/topics/release-notes/),
CHANGELOG.md:* Add optional [jsonapi-style](http://jsonapi.org/format/) filter backends. See [usage docs](docs/usage.md#filter-backends)
CHANGELOG.md:  values from being formatted as attributes can contain any [json value](http://jsonapi.org/format/#document-resource-object-attributes).
README.rst:* Format specification: http://jsonapi.org/format/
README.rst:.. _JSON:API: http://jsonapi.org
README.rst:Read more at http://django-rest-framework-json-api.readthedocs.org/
docs/Makefile:$(error The '$(SPHINXBUILD)' command was not found. Make sure you have Sphinx installed, then set the SPHINXBUILD environment variable to point to the full path of the '$(SPHINXBUILD)' executable. Alternatively you can add the directory with the executable to your PATH. If you don't have Sphinx installed, grab it from http://sphinx-doc.org/)
docs/make.bat:  echo.http://sphinx-doc.org/
docs/usage.md:Many features of the [JSON:API](http://jsonapi.org/format) format standard have been implemented using
docs/usage.md:# compiled regex that matches the allowed http://jsonapi.org/format/#query-parameters
docs/usage.md:`OrderingFilter` implements the [JSON:API `sort`](http://jsonapi.org/format/#fetching-sorting) and uses
docs/usage.md:`DjangoFilterBackend` implements a Django ORM-style [JSON:API `filter`](http://jsonapi.org/format/#fetching-filtering)
docs/usage.md:[JSON:API _recommendations_](http://jsonapi.org/recommendations/#filtering), including relationship
docs/usage.md:all exceptions will respond with the JSON:API [error format](http://jsonapi.org/format/#error-objects).
docs/usage.md:This package includes the ability (off by default) to automatically convert [JSON:API field names](http://jsonapi.org/format/#document-resource-object-fields) of requests and responses from the python/rest_framework's preferred underscore to
docs/usage.md:In the [JSON:API spec](http://jsonapi.org/format/#document-resource-objects),
docs/usage.md:[JSON:API spec](http://jsonapi.org/format/#fetching-relationships)).
docs/usage.md:[Resource Identifier Objects](http://jsonapi.org/format/#document-resource-identifier-objects)
docs/usage.md:[Compound Documents](http://jsonapi.org/format/#document-compound-documents).
rest_framework_json_api/django_filters/backends.py:    http://jsonapi.org/recommendations/#filtering, including relationship
rest_framework_json_api/django_filters/backends.py:    # See http://jsonapi.org/format/#document-member-names for allowed characters
rest_framework_json_api/django_filters/backends.py:    # and http://jsonapi.org/format/#document-member-names-reserved-characters for reserved
rest_framework_json_api/filters.py:    A backend filter that implements http://jsonapi.org/format/#fetching-sorting and
rest_framework_json_api/filters.py:    the rules at http://jsonapi.org/format/#query-parameters.
rest_framework_json_api/filters.py:    #: compiled regex that matches the allowed http://jsonapi.org/format/#query-parameters:

Checklist

  • Certain that this is a bug (if unsure or you have a question use discussions instead)
  • Code snippet or unit test added to reproduce bug
@himanshu007-creator
Copy link

Hi , i would like to work on this issue

@sliverc
Copy link
Member Author

sliverc commented Sep 29, 2021

@himanshu007-creator Sure. Any help is very appreciated.

@SwarajBaral
Copy link
Contributor

Is this issue closed @sliverc ? I would love to contribute in this.

@sliverc
Copy link
Member Author

sliverc commented Oct 4, 2021

@SwarajBaral It seems @himanshu007-creator hasn't had time yet to work on this. As this is a fairly short task as long as no PR hasn't been opened to address this issue feel free to work on it.

@SwarajBaral
Copy link
Contributor

Sure, @sliverc, I will get started right away. So just to be sure, I need to edit all the links in the ./docs directory and change them from http:// to https:// right ?

@sliverc
Copy link
Member Author

sliverc commented Oct 4, 2021

@SwarajBaral yes + some occurrences in readme, changelog and a few doc strings.

Best run the following command to see what needs to change:

$ git grep "http://" | grep -v testserver | grep -v localhost | grep -v "127.0.0.1" | grep -v example.com | grep -v example.org

@SwarajBaral
Copy link
Contributor

Thank you for such a quick response @sliverc. I will get started on it.

@SwarajBaral
Copy link
Contributor

SwarajBaral commented Oct 4, 2021

Hey @sliverc, I have created a pr. Kindly check #989. Please do let me know if I made any errors. I am pretty new to contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants