Introduce flake8 bugbear plugin #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n2ygk
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Bugbear is a plugin for flake8 finding likely bugs and design problems. This PR adds it to DJA and already found some potential issues.
Also, it introduces an optional “line length too long” error which is more pragmatic than the E507 which we had disabled.
Currently, we disable line length altogether and leave it up to black to make it shorter. However, black does not format strings and comments etc. so some lines end up being very long. Bugbear will only flag lines which are longer than ~10% of the maximum length to solve this problem, but not to make the error becoming annoying.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS