Skip to content

Add support for Django 4.2 #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Add support for Django 4.2 #1142

merged 3 commits into from
Apr 4, 2023

Conversation

Tenzer
Copy link
Contributor

@Tenzer Tenzer commented Apr 4, 2023

Allows library to be installed with Django 4.2.

Description of the Change

This broadens the range of Django versions this library allows to be installed alongside to include Django 4.2 and any bugfix releases of it.

It also disables the use of the now deprecated UnsaltedMD5PasswordHasher hashing algorithm when running tests, as it otherwise would raise deprecation warnings. This will make the tests slightly slower since the default password hashing algorithm uses more resources, but it shouldn't have a big impact all in all as the tests run pretty quickly regardless.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Tenzer added 2 commits April 4, 2023 14:36
The tests run pretty quickly regardless, so it should be okay to use the
default password hasher.
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Looks good overall just make sure you do not drop tests for Django 4.1.

@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 4, 2023

Thank you for the review. I have reinstated the Django 4.1 tests now.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks good now.

@sliverc sliverc merged commit 1182281 into django-json-api:main Apr 4, 2023
@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 4, 2023

Great, thanks! Do you know when a new release might be cut? This would be blocking any users of the library from upgrading to Django 4.2.

@sliverc
Copy link
Member

sliverc commented Apr 5, 2023

This kind of depends on when DRF will release a new version supporting Django 4.2. @auvipy Do you have more information when there will be a new DRF release?

@Tenzer
Copy link
Contributor Author

Tenzer commented Apr 5, 2023

It looks like encode/django-rest-framework#8794 is the relevant issue to track regards a new release.

@auvipy
Copy link
Contributor

auvipy commented Apr 8, 2023

This kind of depends on when DRF will release a new version supporting Django 4.2. @auvipy Do you have more information when there will be a new DRF release?

I contacted with Tom but he seem to be busy. I hoe we can cut a release in late this month or early next month.

@abmohan
Copy link

abmohan commented May 21, 2023

Thanks for working on this. I'm looking forward to upgrading to django 4.2. What's the release schedule looking like? How long do you think we'd have to wait for this?

@sliverc
Copy link
Member

sliverc commented Jun 12, 2023

@abmohan We are still waiting on DRF to release 3.15 with Django 4.2 support. @auvipy Do you have any update when this will be ready? Thanks.

@auvipy
Copy link
Contributor

auvipy commented Jun 12, 2023

In practice 3.15 did not need any code change for django 4.2 support. But I am still waiting for a response from Tom

@elanqo
Copy link

elanqo commented Aug 9, 2023

@sliverc, When do you anticipate publishing these changes to PyPI?

@max-wittig
Copy link

@sliverc We're using DRF with 4.2 in production from the latest release. According to their README it should be already supported. Sorry, if I missed something here and just jumped in without knowning something important. Just wanted to state the obvious (it works with 4.2) 😄

@sliverc
Copy link
Member

sliverc commented Aug 25, 2023

DRF 3.15 seems to take longer than anticipated. So I released it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants