Skip to content

Add pull request template #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented May 1, 2018

Assist requester and reviewer to a more streamlined PR acceptance process.

Please comment if you see any other items added to checklist.

@sliverc sliverc requested a review from n2ygk May 1, 2018 13:24
@codecov-io
Copy link

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   91.75%   91.75%           
=======================================
  Files          55       55           
  Lines        2923     2923           
=======================================
  Hits         2682     2682           
  Misses        241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3dfa29...925ecad. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mblayman - Are you OK with me merging this? It would be my first;-) Seems a pretty safe one!

@mblayman
Copy link
Collaborator

mblayman commented May 1, 2018

@n2ygk, yeah, LGTM.

@n2ygk n2ygk merged commit f1e6e1d into django-json-api:master May 1, 2018
@sliverc sliverc deleted the pull_request_template branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants