Skip to content

Improve REST_FRAMEWORK settings recommendation #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2018
Merged

Improve REST_FRAMEWORK settings recommendation #444

merged 1 commit into from
Jul 12, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jul 12, 2018 •
edited
Loading

Partially addresses #432

Description of the Change

Improve REST_FRAMEWORK settings recommendation including:

  • Testing configuration as explained here
  • Sorting configuration according to json api spec

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk July 12, 2018 08:10
@sliverc sliverc force-pushed the document_settings branch from 082f6ed to 3fe349d Compare July 12, 2018 08:14
@codecov-io
Copy link

codecov-io commented Jul 12, 2018 •
edited
Loading

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          54       54           
  Lines        2858     2858           
=======================================
  Hits         2649     2649           
  Misses        209      209
Impacted Files Coverage Δ
example/settings/dev.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2619f45...3fe349d. Read the comment docs.

n2ygk
n2ygk approved these changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I look forward to learning how to use those filter backends the correct way!

@n2ygk n2ygk merged commit e33df0a into django-json-api:master Jul 12, 2018
@sliverc sliverc deleted the document_settings branch July 13, 2018 06:45
@n2ygk n2ygk added this to the 2.6.0 milestone Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sliverc @codecov-io @n2ygk