Skip to content

Format field names for metadata (OPTIONS request) #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Format field names for metadata (OPTIONS request) #500

wants to merge 5 commits into from

Conversation

mstdokumaci
Copy link

Description of the Change

Field names are represented wrong in OPTIONS call if you use JSON_API_FORMAT_FIELD_NAMES in settings. This patch fixes metadata.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

Field names are represented wrong in OPTIONS call if you use `JSON_API_FORMAT_FIELD_NAMES` in settings. This patch fixes metadata.
@sliverc sliverc self-requested a review October 23, 2018 13:09
@sliverc sliverc added the bug label Oct 23, 2018
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Indeed good to format the values in metadata as well.

Please follow up on the other TODO check boxes on the PR and fixing of linting so we can merge this.

@sliverc
Copy link
Member

sliverc commented Oct 2, 2019

Closing as implemented in #713

@sliverc sliverc closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants