Allow partial update with polymorphic serializers #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. Could you add a test to ensure that this fix works and a changelog entry? Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
=======================================
Coverage 96.13% 96.13%
=======================================
Files 56 56
Lines 2869 2869
=======================================
Hits 2758 2758
Misses 111 111Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 96.13% 96.14% +0.01%
==========================================
Files 56 57 +1
Lines 2869 2879 +10
==========================================
+ Hits 2758 2768 +10
Misses 111 111
Continue to review full report at Codecov.
|
sliverc
force-pushed
the
bugfix/polymorphic-partial-update
branch
from
6b51632 to
f0211f5
Compare
sliverc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Passes the partial argument to the subclass of a polymorphic serializer when
to_internal_valueis called. This prevents a validation error being raised if you don't provide all fields when making a PATCH request to the resource.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS