Skip to content

support only drf 3.12 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

support only drf 3.12 #833

merged 1 commit into from
Oct 5, 2020

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Sep 29, 2020

Fixes #832

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 4.0.0 milestone Sep 29, 2020
@n2ygk n2ygk requested a review from sliverc September 29, 2020 14:49
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #833 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #833   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          58       58           
  Lines        3158     3158           
=======================================
  Hits         3066     3066           
  Misses         92       92           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d012c02...8e467c0. Read the comment docs.

@n2ygk
Copy link
Contributor Author

n2ygk commented Oct 5, 2020

Wait. this latest push is incorrect. Should only test drf 3.12... Standby, testing again. This is not meant to be merged until 4.0....

@sliverc
Copy link
Member

sliverc commented Oct 5, 2020

We already have backwards incompatible changes in master so next version will be 4.0.0 in any case. So merging this.

Thanks.

@sliverc sliverc merged commit e130666 into django-json-api:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DRF 3.12 support
3 participants