Skip to content

Stopped SparseFieldsetsMixin interpreting invalid fields parameter #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 15, 2020

Fixes #519

Description of the Change

Stopped SparseFieldsetsMixin interpreting invalid fields query parameter

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 15, 2020 14:43
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #842 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   97.76%   97.77%   +0.01%     
==========================================
  Files          58       58              
  Lines        3089     3104      +15     
==========================================
+ Hits         3020     3035      +15     
  Misses         69       69              
Impacted Files Coverage Δ
example/tests/integration/test_sparse_fieldsets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09b85d...0371405. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops. Thanks for the fix!

@n2ygk n2ygk merged commit 7efea43 into django-json-api:master Oct 16, 2020
@sliverc sliverc deleted the sparse_fieldsets_parameter branch December 28, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SparseFieldsetsMixin catches invalid key from URL
2 participants