Skip to content

Support many related fields on plain Serializers #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Support many related fields on plain Serializers #868

merged 3 commits into from
Dec 11, 2020

Conversation

nattyg93
Copy link
Contributor

@nattyg93 nattyg93 commented Dec 4, 2020

Fixes #704

Description of the Change

Fix issue preventing resolving the resource type of ResourceRelatedField(many=True) fields on plain serializers

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • [n/a] documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #868 (9d654fe) into master (3263061) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files          60       60           
  Lines        3319     3319           
=======================================
  Hits         3244     3244           
  Misses         75       75           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3263061...9d654fe. Read the comment docs.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! See my inline comment.

@sliverc
Copy link
Member

sliverc commented Dec 11, 2020

LGTM. Thanks for your work.

@sliverc sliverc merged commit 3833271 into django-json-api:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including lists of resources from non-model annotated objects
2 participants