Skip to content

Do not ignore F405 linting error #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/settings/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
JSON_API_FORMAT_TYPES = "camelize"
JSON_API_PLURALIZE_TYPES = True

REST_FRAMEWORK.update(
REST_FRAMEWORK.update( # noqa: F405
{ # noqa
"PAGE_SIZE": 1,
}
Expand Down
15 changes: 14 additions & 1 deletion rest_framework_json_api/serializers.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,22 @@
from collections import OrderedDict

import inflection
from django.core.exceptions import ObjectDoesNotExist
from django.db.models.query import QuerySet
from django.utils.translation import gettext_lazy as _
from rest_framework.exceptions import ParseError
from rest_framework.serializers import * # noqa: F403

# star import defined so `rest_framework_json_api.serializers` can be
# a simple drop in for `rest_framework.serializers`
from rest_framework.serializers import * # noqa: F401, F403
from rest_framework.serializers import (
BaseSerializer,
HyperlinkedModelSerializer,
ModelSerializer,
Serializer,
SerializerMetaclass,
)
from rest_framework.settings import api_settings

from rest_framework_json_api.exceptions import Conflict
from rest_framework_json_api.relations import ResourceRelatedField
Expand Down
5 changes: 1 addition & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ extend-ignore =
# whitespace before ':' - disabled as not PEP8 compliant
E203,
# line too long (managed by black)
E501,
# usage of star imports
# TODO mark star imports directly in code to ignore this error
F405
E501
exclude =
build/lib,
.eggs
Expand Down