Restore disabled flake8 tests #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove '--exit-zero' so flake8 errors will actually cause a travis failure. - restore flake8-quotes. (I may prefer single quotes but @jlelanche has decreed they shall be double. Obey!) - fix various isort and flake8 (mostly single vs. double quotes) errors that crept in since the tests were disabled.
|
@jleclanche must have a français de Suisse keyboard. In 'murica we prefer single quotes as they don't require the shift key;-) |
Pull Request Test Coverage Report for Build 1299
💛 - Coveralls |
auvipy
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #796
Description of the Change
Restore flake8 tests that were disabled with
--exit-zeroand commenting outflake8-quotesRequired a few minor syntax changes a handful of files.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS