Reject generator functions in sync_to_async - #566
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sync_to_async()with the existing TypeError path__call__methodsync_to_async()currently calls a generator function in the worker thread only far enough to create the generator object. Iterating that generator then runs the body in the caller thread, which is the confusing behavior reported in the issue. Raising early is safer than returning an object that does not actually execute under the adapter.Fixes #38
Tests
python -m pytest tests\test_sync.py -qpython -m pytest -qpython -m mypy asgiref tests\test_sync.pygit diff --check