You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The regression test failed before the production change because the handled timeout left the current task's cancellation count at 1 instead of restoring it to 0.
pytest tests/test_testing.py -q
pytest -q — 98 passed, 1 xfailed on Python 3.12
mypy .
pre-commit run --files asgiref/testing.py tests/test_testing.py
We're dropping Python 3.10 very shortly. I wonder if the correct approach here isn't to switch testing.py to asyncio.timeout instead, and deprecate timeout.py here. (We might merge this anyway...)
Rebased and revised this along the suggested compatibility boundary. ApplicationCommunicator now uses asyncio.timeout on Python 3.11+, while Python 3.10 keeps the existing vendored fallback unchanged.
I moved the regression coverage to ApplicationCommunicator.receive_output; it confirms that a handled timeout no longer leaves the caller task in a cancelling state. The full test suite and mypy pass on Python 3.10 and 3.14, with focused checks on Python 3.11 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.timeoutforApplicationCommunicatoron Python 3.11+receive_outputtimeoutRelated to #504.
Verification
The regression test failed before the production change because the handled timeout left the current task's cancellation count at
1instead of restoring it to0.pytest tests/test_testing.py -qpytest -q— 98 passed, 1 xfailed on Python 3.12mypy .pre-commit run --files asgiref/testing.py tests/test_testing.py