Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

Marenz
Copy link

@Marenz Marenz commented Apr 7, 2016

No description provided.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
15895 Make rt_trapExceptions apply to fibers as well

@Marenz
Copy link
Author

Marenz commented Apr 15, 2016

Ping.

@Marenz
Copy link
Author

Marenz commented May 1, 2016

Ping

@Marenz
Copy link
Author

Marenz commented May 1, 2016

It would be nice to get some feedback or at least any reaction to this.

@Marenz
Copy link
Author

Marenz commented May 5, 2016

@MartinNowak trying a direct hilight

@adamdruppe
Copy link
Contributor

So, I'm not as confident here because I don't use fibers but I think it is a good idea too.

@mathias-baumann-sociomantic

@MartinNowak ping ping ping

@dnadlinger
Copy link
Contributor

dnadlinger commented Aug 15, 2016

One potential issue I see here is that Fiber.call actually documents how unhandled exceptions are treated (calling context resumes), and it even has a switch to set that behaviour. Is rt_trapExceptions actually documented anywhere?

@mathias-baumann-sociomantic

Only documentation I know of for this is

druntime/src/rt/dmain2.d

Lines 142 to 144 in 15a2274

// This variable is only ever set by a debugger on initialization so it should
// be fine to leave it as __gshared.
extern (C) __gshared bool rt_trapExceptions = true;

I can change the docu for Fiber.call to mention the behavior when rt_trapExceptions is set

@dlang-bot dlang-bot added Needs Rebase needs a `git rebase` performed stalled Needs Work labels Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Rebase needs a `git rebase` performed Needs Work stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants