Skip to content

Conversation

rainers
Copy link
Member

@rainers rainers commented Nov 3, 2017

  • grabs mingw from it's repository
  • builds import libraries from mingw definition files
  • builds stub for msvcr100.dll
  • creates installer using these sdk libraries and lld-link

I couldn't test build_all though because it only runs on linux.

I'm also a bit confused about the use of the create_dmd_release_extra folder: it seems they do not end up in the result directory/zip. Instead link.exe is expected create_dmd_release\extras\dmd2\windows\bin, not in the additional extras. So what's the point of the committed extra folders?

This depends on dlang/tools#267
The dmd/phobos sources should have dlang/dmd#7261 and dlang/phobos#5839 applied.

- grabs mingw from it's repository
- builds import libraries from mingw definition files
- builds stub for msvcr100.dll
- creates installer using these sdk libraries and lld-link
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@MartinNowak
Copy link
Member

Great, I'll try to test and review this for the upcoming beta.
The additional extras was necessary to copy over binary-only tools, like obj2asm.

@MartinNowak MartinNowak added this to the 2.078.0 milestone Dec 12, 2017
@MartinNowak
Copy link
Member

Can we find a more descriptive name for this toolchain @rainers ? How about dmd-lld?
Also this should get a changelog entry, describing this (and an experimental warning I guess).

Just copy the changelog/README.md from dmd or so, installer changelogs are already supported.
https://github.com/dlang/tools/blob/40b1efb88550c6a2daea2b8c2d03177a502ce684/changed.d#L409

@MartinNowak
Copy link
Member

Should we try to integrate this with the normal dmd installer right away? Adding more choices might cause unnecessary confusion.

@rainers
Copy link
Member Author

rainers commented Dec 12, 2017

Should we try to integrate this with the normal dmd installer right away?

It's probably the simplest way to get people to test it.
The installer in this PR also includes the "sdk" in the normal distribution, there's just a different default sc.ini.
The VS auto-detection has been merged (dlang/dmd#7393), if we include lld and the "light sdk", it should be added to the auto-detection mechanism, too.

@MartinNowak MartinNowak removed this from the 2.078.0 milestone Dec 16, 2017
@MartinNowak
Copy link
Member

I'm for integrating this as a VC fallback with the normal release (for -m32mscoff, -m64).

@rainers
Copy link
Member Author

rainers commented Dec 24, 2017

I'm for integrating this as a VC fallback with the normal release (for -m32mscoff, -m64).

Done in #281. Closing in favor of that.

@rainers rainers closed this Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants