FileManagerInputWidget - fix/enhance item search from fileflyModule API #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
handcode
commented
Jan 16, 2025
handcode
commented
- make currently hardcoded properties like minimumInputLength configurable via widget properties
- make select2 data callback name dynamic, so we can configure the callback for each widget instance
- enhance item formating to e.g. be able to display thumbnails
- will require dmstr/yii2-filefly-module > 1.7.3
- make currently hardcoded properties like minimumInputLength configurable via widget properties - make select2 data callback name dynamic, so we can configure the callback for each widget instance - enhance item formating to e.g. be able to display thumbnails - will require dmstr/yii2-filefly-module > 1.7.3
eluhr
reviewed
Jan 16, 2025
| @@ -71,11 +121,11 @@ public function init() | |||
| 'url' => $this->to('search', null), | |||
| 'dataType' => 'json', | |||
| 'delay' => 220, | |||
| 'data' => new JsExpression('searchData'), | |||
| 'data' => new JsExpression($this->jsGetSearchDataFuncName), | |||
There was a problem hiding this comment.
Maybe you should add an if(is_string) (or similar) around that because the JSExpression returns an empty string ('') for an empty value (null) and that could lead to problems.
There was a problem hiding this comment.
I'm a big fan of checks before using variables anywhere, but in this case a protected variable is used which is set in the int() of the widget (see line 108). So I don't see a scenario here where the variable could be set “incorrectly” or have i missed something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.