This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Update voting-app example #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinebriaud
force-pushed
the
fix-vapp-example
branch
from
8da9efd to
56a36d2
Compare
rumpl
reviewed
Nov 21, 2019
rumpl
reviewed
Nov 21, 2019
rumpl
reviewed
Nov 21, 2019
rumpl
reviewed
Nov 21, 2019
ndeloof
approved these changes
Nov 21, 2019
carolinebriaud
force-pushed
the
fix-vapp-example
branch
from
56a36d2 to
8aea17b
Compare
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=========================================
Coverage ? 69.15%
=========================================
Files ? 64
Lines ? 3469
Branches ? 0
=========================================
Hits ? 2399
Misses ? 751
Partials ? 319Continue to review full report at Codecov.
|
rumpl
reviewed
Nov 21, 2019
| result.port 9000 | ||
| vote.port 8080 | ||
| vote.replicas 5 | ||
| Now, we will update the running App to overwrite the current parameters with the production parameters we created at the previous step. |
There was a problem hiding this comment.
Suggested change
| Now, we will update the running App to overwrite the current parameters with the production parameters we created at the previous step. | |
| Now, we will update the running App to overwrite the current parameters with the production parameters we created in the previous step. |
Signed-off-by: Caroline Briaud <[email protected]>
carolinebriaud
force-pushed
the
fix-vapp-example
branch
from
8aea17b to
5b75fab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Caroline Briaud [email protected]
- What I did
Update voting-app example to take into account UX changes
Fix a typo in hello-world example
- How to verify it
Check the readme and file renamed
- A picture of a cute animal (not mandatory)
