-
Notifications
You must be signed in to change notification settings - Fork 877
upgraded gunicorn, removed deprecated flag, and added timezone to logging #519
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,9 +22,6 @@ | |
port = env.source('REGISTRY_PORT') | ||
app.debug = True | ||
app.run(host=host, port=port) | ||
# Or you can run: | ||
# gunicorn --access-logfile - --log-level debug --debug -b 0.0.0.0:5000 \ | ||
# -w 1 wsgi:application | ||
else: | ||
# For uwsgi | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why remove the --debug switch? (here and elsewhere) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On Tue, Aug 12, 2014 at 09:27:49AM -0700, Olivier Gambier wrote:
Because it's useless ;) [1,2]. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing useless stuff indeed seems like an acceptable reason (note that in v18, --debug or its absence had strange side-effects on logging IIRC) - but since we are moving up, I'm happy :-) |
||
app.logger.setLevel(logging.INFO) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @shin- - any objection to that? anything we do with the logs in production?