Skip to content

feat: remove unused files #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2018
Merged

feat: remove unused files #232

merged 2 commits into from
Aug 22, 2018

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Aug 17, 2018

remove unused files to reduce the size of the layer.
389MB -> 255MB

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@tianon
Copy link
Member

tianon commented Aug 17, 2018

Are these directories documented somewhere as being safe to remove post-build? (so we can link back to something to note why we do so)

@orisano
Copy link
Contributor Author

orisano commented Aug 17, 2018

about: /usr/local/go/pkg/bootstrap
https://github.com/golang/go/blob/master/src/cmd/dist/buildtool.go#L121-L125

// Use $GOROOT/pkg/bootstrap as the bootstrap workspace root.
// We use a subdirectory of $GOROOT/pkg because that's the
// space within $GOROOT where we store all generated objects.
// We could use a temporary directory outside $GOROOT instead,
// but it is easier to debug on failure if the files are in a known location.

@orisano
Copy link
Contributor Author

orisano commented Aug 17, 2018

about: /usr/local/go/pkg/obj/go-build/
it is a cache directory.
https://groups.google.com/forum/#!topic/golang-dev/qfa3mHN4ZPA

please read this issue:
golang/go#23299
https://go-review.googlesource.com/c/build/+/82095

@yosifkit
Copy link
Member

cmd/release: delete go/pkg/obj

There's no point to keeping this in releases.
It probably shouldn't be created at all, but since it is,
delete it.

https://go-review.googlesource.com/c/build/+/82095

😄

Verified

This commit was signed with the committer’s verified signature.
heitorlessa Heitor Lessa
@tianon tianon merged commit 045f1da into docker-library:master Aug 22, 2018
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 22, 2018

Verified

This commit was signed with the committer’s verified signature.
heitorlessa Heitor Lessa
- `docker`: 18.06.1-ce GA
- `ghost`: Ghost 2.0! (docker-library/ghost#145)
- `golang`: remove unused files (docker-library/golang#232)
- `postgres`: add `stretch-backports` when building 11+ from source (docker-library/postgres#485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants