Add temporary "freetype-config" workaround for PHP 7.3, 7.2, and 7.1 on buster #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on buster See: - docker-library#865 - https://bugs.php.net/bug.php?id=76324 - php/php-src#3632 - php/php-src@2d03197 This is not necessary for Debian Stretch (where `freetype-config` still exists) nor PHP 7.4+ (where `pkg-config` is used instead/in addition).
|
I verified this hack works as intended via the following patch to diff --git a/8.7/apache/Dockerfile b/8.7/apache/Dockerfile
index 5c0d588..24654f5 100644
--- a/8.7/apache/Dockerfile
+++ b/8.7/apache/Dockerfile
@@ -1,7 +1,9 @@
# from https://www.drupal.org/docs/8/system-requirements/drupal-8-php-requirements
-FROM php:7.3-apache-stretch
+FROM php:7.3-apache-buster
# TODO switch to buster once https://github.com/docker-library/php/issues/865 is resolved in a clean way (either in the PHP image or in PHP itself)
+RUN { echo '#!/bin/sh'; echo 'exec pkg-config "$@" freetype2'; } > /usr/local/bin/freetype-config && chmod +x /usr/local/bin/freetype-config
+
# install the PHP extensions we need
RUN set -eux; \
\(Which would otherwise fail without applying this workaround.) |
yosifkit
approved these changes
Jul 22, 2019
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jul 22, 2019
Changes: - docker-library/php@a74d01a: Merge pull request docker-library/php#869 from infosiftr/freetype-config - docker-library/php@a0ce8af: Add temporary "freetype-config" workaround for PHP 7.3, 7.2, and 7.1 on buster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
This is not necessary for Debian Stretch (where
freetype-configstill exists) nor PHP 7.4+ (wherepkg-configis used instead/in addition).Closes #865