Skip to content

Add support for docker run --group-add option #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ndeloof opened this issue Apr 14, 2016 · 13 comments
Closed

Add support for docker run --group-add option #3328

ndeloof opened this issue Apr 14, 2016 · 13 comments

Comments

@ndeloof
Copy link
Contributor

ndeloof commented Apr 14, 2016

For container to access host docker daemon, I use to bind mount /var/run/docker.sock and docker executable. But then I also need to add docker group to the container user so it can access the socket. For this purpose I use docker run --group-add option, but can't find how to do the same with docker-compose.

@pwFoo
Copy link

pwFoo commented Jul 2, 2016

Any schedule to add "--group-add" to docker-compose?

@Knetic
Copy link

Knetic commented Jul 8, 2016

I needed this too, and took a crack at it with PR #3709.

@pwFoo
Copy link

pwFoo commented Sep 1, 2016

Thanks, @Knetic !
I'll follow #3709

@arno01
Copy link

arno01 commented Nov 16, 2016

It was merged and is available in 1.9.0-rc4 https://github.com/docker/compose/releases :-]
I think this issue can be closed.

@psoares
Copy link

psoares commented Apr 6, 2017

I couldn't get this to work. The documentation seems wrong : it displays a snippet like this :

version: '3'
services:
    image: alpine
    group_add:
      - mail

Running docker-compose with this returns Unsupported config option for services: 'group_add'

I tried this too :

version: '3'
services:
    myservice:
        image: alpine
        group_add:
          - mail

Running docker-compose with this returns Unsupported config option for services.myservice: 'group_add'

Is the option available somehow and the bug is just in the documentation ?

@psoares
Copy link

psoares commented Apr 7, 2017

I fixed my examples to reflect what I actually tested, which was version: '3', not version: '2'

@Shingaz
Copy link

Shingaz commented Apr 24, 2017

@psoares group_add feature has been removed in version 3. See: https://docs.docker.com/compose/compose-file/compose-versioning/#version-3

@head1328
Copy link

head1328 commented Aug 8, 2017

Is there any reason why they removed group_add support?

@mattwilmott
Copy link

Yeah I mean the migration doco doesn't exactly spell out the alternative...

"group_add: This option has been removed for version: "3.x" Compose files."

Similar to others, I'm hoping to expose the underlying docker socket in a Jenkins container

@anthony-bernardo
Copy link

How to do now ??

@kavehv
Copy link

kavehv commented Aug 15, 2018

Agree with the others here, why was this removed without any explanation?

@moble
Copy link

moble commented Aug 28, 2018

This comment suggests that this is not the appropriate repo for this request. (I don't understand any of this.) Anyway, as suggested, I've created an issue requesting this over here.

@ijc
Copy link

ijc commented Mar 29, 2019

Issue grooming: dada36f added this for v2 it seems. The issue with v3 support is different and according to the preceding comments are already reported in the appropriate places.

@ijc ijc closed this as completed Mar 29, 2019
thecodingdoc1 added a commit to thecodingdoc1/strongbox-docs that referenced this issue Jun 17, 2019
The use of a comma is needed because there is a list of items. Starting with [docker/compose#3328][issue-3328]. It includes this issue, issue 4700, and finally issue 1318. There should be a comma before the and in a list.

Co-Authored-By: Steve Todorov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests