-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add support for docker run --group-add option #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any schedule to add "--group-add" to docker-compose? |
I needed this too, and took a crack at it with PR #3709. |
It was merged and is available in 1.9.0-rc4 https://github.com/docker/compose/releases :-] |
I couldn't get this to work. The documentation seems wrong : it displays a snippet like this : version: '3'
services:
image: alpine
group_add:
- mail Running docker-compose with this returns I tried this too : version: '3'
services:
myservice:
image: alpine
group_add:
- mail Running docker-compose with this returns Is the option available somehow and the bug is just in the documentation ? |
I fixed my examples to reflect what I actually tested, which was version: '3', not version: '2' |
@psoares |
Is there any reason why they removed group_add support? |
Yeah I mean the migration doco doesn't exactly spell out the alternative... "group_add: This option has been removed for version: "3.x" Compose files." Similar to others, I'm hoping to expose the underlying docker socket in a Jenkins container |
How to do now ?? |
Agree with the others here, why was this removed without any explanation? |
This comment suggests that this is not the appropriate repo for this request. (I don't understand any of this.) Anyway, as suggested, I've created an issue requesting this over here. |
Issue grooming: dada36f added this for v2 it seems. The issue with v3 support is different and according to the preceding comments are already reported in the appropriate places. |
The use of a comma is needed because there is a list of items. Starting with [docker/compose#3328][issue-3328]. It includes this issue, issue 4700, and finally issue 1318. There should be a comma before the and in a list. Co-Authored-By: Steve Todorov <[email protected]>
For container to access host docker daemon, I use to bind mount
/var/run/docker.sock
anddocker
executable. But then I also need to adddocker
group to the container user so it can access the socket. For this purpose I use docker run--group-add
option, but can't find how to do the same with docker-compose.The text was updated successfully, but these errors were encountered: