Clarify what happens when a failed swarm node recovers #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thaJeztah PTAL |
thaJeztah
reviewed
Oct 10, 2016
|
|
||
| If a node becomes unavailable, it cannot communicate with the rest of the swarm. | ||
| If access to that node is restored, it will re-join the swarm, but it will | ||
| function as a completely new node. In fact, when it first re-joins, its current |
There was a problem hiding this comment.
Wonder if we should say "as a completely new node" here (as it still has the same node ID, unless it really left the swarm, and re-joined using docker swarm join).
/cc @aaronlehmann any suggestions?
There was a problem hiding this comment.
I agree. Let's not say that re-joins the swarm, because according to our terminology, it never really left; it was just unreachable for a period of time. During that time, its workload would have been rescheduled elsewhere.
|
Thanks for the feedback. I've reworded it a bit. Can y'all review it again? |
|
I don't see the changes - looks like they haven't been pushed yet. |
|
Oops, you are right! Should be pushed now. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105