-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Change 'alias:' to 'redirect_from:' so aliases work again #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just for reference, from https://github.com/jekyll/jekyll-redirect-from, it seems that the redirect paths should end with a trailing slash. |
@johndmulhausen let me know that he thought we should still be using the alias functionality rather than redirect_from, and that there might be a bug that is causing the redirect problem that Vicky reported elsewhere. I'd like him to look at it when he comes back from vacation before we decide whether we want to make this change or fix that bug. Maybe he can explain to us why we shouldn't use redirect_from. I think it actually creates the old HTML file with a 302 redirect to the new one, and maybe he thought it would make Jenkins take longer. But let's let him give more details. |
@@ -581,10 +581,10 @@ In the example below, three services are provided (`web`, `worker`, and `db`), a | |||
image: mysql | |||
networks: | |||
new: | |||
aliases: | |||
redirect_from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erroneous replacement
- database | ||
legacy: | ||
aliases: | ||
redirect_from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erroneous replacement
- /docker-cloud/getting-started/use-hosted/ | ||
description: How to link Docker Cloud to a hosted cloud services provider or your | ||
own hosts | ||
keywords: | ||
- node, create, understand | ||
menu: | ||
main: | ||
aliases: | ||
redirect_from: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be moved up to root of front matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is a dupe
@@ -1,5 +1,5 @@ | |||
--- | |||
aliases: [] | |||
redirect_from: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
@@ -1,5 +1,5 @@ | |||
--- | |||
aliases: [] | |||
redirect_from: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
@@ -1,5 +1,5 @@ | |||
--- | |||
aliases: [] | |||
redirect_from: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
Added some comments; will be looking at build times. This might be preferred after all so we stop throwing 404s |
Signed-off-by: Misty Stanley-Jones <[email protected]>
@johndmulhausen PTAL, I think this is ready. FYI, here is the magic command I used:
This only replaces |
Made a few nips/tucks for consistency, but this looks great, thank you! |
@londoncalling @johndmulhausen PTAL, I think this is why our aliases don't work. :)