Fix quotes on webhook JSON example #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "dockerfile": "#\n# BUILD\u0009\u0009docker build -t svendowideit/apt-cacher .\n# RUN\u0009\u0009docker run -d -p 3142:3142 -name apt-cacher-run apt-cacher\n#\n# and then you can run containers with:\n# \u0009\u0009docker run -t -i -rm -e http_proxy http://192.168.1.2:3142/ debian bash\n#\nFROM\u0009\u0009ubuntu\nMAINTAINER\[email protected]\n\n\nVOLUME\u0009\u0009[\/var/cache/apt-cacher-ng\]\nRUN\u0009\u0009apt-get update ; apt-get install -yq apt-cacher-ng\n\nEXPOSE \u0009\u00093142\nCMD\u0009\u0009chmod 777 /var/cache/apt-cacher-ng ; /etc/init.d/apt-cacher-ng start ; tail -f /var/log/apt-cacher-ng/*\n, | ||
| full_description: Docker Hub based automated build from a GitHub repo", | ||
| "dockerfile": "#\n# BUILD\u0009\u0009docker build -t svendowideit/apt-cacher .\n# RUN\u0009\u0009docker run -d -p 3142:3142 -name apt-cacher-run apt-cacher\n#\n# and then you can run containers with:\n# \u0009\u0009docker run -t -i -rm -e http_proxy http://192.168.1.2:3142/ debian bash\n#\nFROM\u0009\u0009ubuntu\nMAINTAINER\[email protected]\n\n\nVOLUME\u0009\u0009[\/var/cache/apt-cacher-ng\]\nRUN\u0009\u0009apt-get update ; apt-get install -yq apt-cacher-ng\n\nEXPOSE \u0009\u00093142\nCMD\u0009\u0009chmod 777 /var/cache/apt-cacher-ng ; /etc/init.d/apt-cacher-ng start ; tail -f /var/log/apt-cacher-ng/*\n", | ||
| "full_description": Docker Hub based automated build from a GitHub repo", |
There was a problem hiding this comment.
Shouldn't there be another quote between : and Docker on this line?
There was a problem hiding this comment.
Good catch, updated.
johndmulhausen
approved these changes
Oct 31, 2016
joaofnfernandes
pushed a commit
to joaofnfernandes/docker.github.io
that referenced
this pull request
Nov 1, 2016
Signed-off-by: Matt Bentley <[email protected]>
|
Thanks, @joshdover :) |
joaofnfernandes
pushed a commit
to joaofnfernandes/docker.github.io
that referenced
this pull request
Nov 2, 2016
Signed-off-by: Matt Bentley <[email protected]>
joaofnfernandes
pushed a commit
to joaofnfernandes/docker.github.io
that referenced
this pull request
Nov 11, 2016
Signed-off-by: Matt Bentley <[email protected]>
joaofnfernandes
pushed a commit
to joaofnfernandes/docker.github.io
that referenced
this pull request
Apr 16, 2018
* Recreate test.md * Add deep-2.0 tab; start template port
JimGalasyn
pushed a commit
that referenced
this pull request
Apr 16, 2018
* Recreate test.md * Add deep-2.0 tab; start template port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little clean up.
P.S. Github diffs are freaking out, but this is correct.