Skip to content
This repository was archived by the owner on Nov 29, 2023. It is now read-only.

gha: also trigger on pull requests, not just "push" #180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thaJeztah
Copy link
Member

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory)

Copy link
Collaborator

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

hmm.. so looks like many tests require a token, which is not available on (external) PRs;

--- FAIL: TestAuthenticationFlagFailsWithImage (0.15s)
Error:     auth_test.go:65: assertion failed: token is "": E2E_TEST_AUTH_TOKEN needs to be filled

So either we need to skip those tests on PRs, or have some other way to run them 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants