Fixes bug where usage parsing fails on multiple blank lines. #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a sample that fails and should pass? I want to test it against the Python one for conformance. (Also, that sample would then make a great unit test). |
|
Actually let me close this out until I can test it further. This fix was originally made last year on Linux on an air-gapped network… I forget the exact way I was seeing the bug, and upon testing now, it looks like this change may introduce bugs of its own, at least on Mac. Sorry for the trouble. I'll create another pull request if I can get this nailed down and tested. What Windows compilers do you test on? |
|
I can't recall ... I dont have Windows machines myself, though others have tried it. The README states some of the compilers that we supprot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny change to the regex allows multiple blank lines to appear in the usage string.