Skip to content

Embed with :type=code replacing entire page when other embeds are present #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
randName opened this issue Mar 17, 2020 · 5 comments
Closed
1 task done
Labels

Comments

@randName
Copy link

randName commented Mar 17, 2020

Bug Report

(potentially related to #791 and #866 or #970)

Steps to reproduce

Include a file as a .html and then as a code block, i.e.

[embed](embed.html ':include')

[source](embed.html ':include :type=code :fragment=demo')

raw files

rendered version

Tested in Chrome, Firefox and Edge

What is current behaviour

The code block overwrites the page content (after a short delay).

The order of embedding does not matter, and even if the linked files are different this will happen.

If either block is removed there is no issue, and it seems unrelated to the fragment nor highlight type.

What is the expected behaviour

Multiple embed blocks remain visible.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Windows 10 x64

  • Browser version: Chrome 80.0.3987.132

  • Docsify version: latest (4.11.2)

  • Docsify plugins: None

@anikethsaha
Copy link
Member

we do have a issue with multiple embedding!

I need to look in it !

Feel free to investigate and submit the fix

@kerim
Copy link

kerim commented Jun 14, 2020

I am having a similar issue. Not with type=code, but just with multiple embeds. The entire page gets replaced with one of the embeds, until I do a browser refresh.

@sebastienbarbier
Copy link

I am having this issue with latest @4, may be roll back to a previous version might be temporary solution ? anyone know when this issue first appears ?

@madhavarshney
Copy link

I'm can confirm this as well. Are there any known workarounds?

madhavarshney added a commit to madhavarshney/docsify that referenced this issue Aug 1, 2020
madhavarshney added a commit to madhavarshney/docsify that referenced this issue Aug 1, 2020
@madhavarshney
Copy link

This bug has been fixed in the latest version of docsify with the upgrade to marked. The demo linked above is also working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants